Add more tests of package traversal #906
Conversation
|
@LecrisUT this PR should capture some of the cases you mentioned in #808 (comment). Are there others that you would like to see added? |
|
Looks promising :). I'll need to draw it out on a paper to follow it 😅 , I'll come back to you after that. At first glance, I think the only part not covered is having both relative and absolute paths in the |
| from importlib.readers import MultiplexedPath | ||
| import pkg | ||
| import pathlib | ||
| print({check}) |
There was a problem hiding this comment.
This should be assert instead of print. Could you also move check to be in-lined here instead of a parameter?
There was a problem hiding this comment.
Rather than asserting here, I print the boolean result and assert the string value outside because asserting inside a subprocess requires significantly more post-processing to handle cleanly.
This PR adds tests (including some xfailed ones) demonstrated patterns of package/subpackage access via import and importlib that are expected to work correctly for both normal and editable installs. Related to #807.